FAC-97 perf: add pagination to curriculum list endpoints#213
Merged
Conversation
Curriculum list endpoints (/departments, /programs, /courses) returned
unbounded result sets. Add page/limit query params via PaginationQueryDto
and return paginated { data, meta } responses using findAndCount, matching
the pattern used by admin, faculty, and dimensions modules.
https://claude.ai/code/session_01Ug6JLCMPhy42Skcq7tWyVV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pageandlimitquery params to/curriculum/departments,/curriculum/programs, and/curriculum/coursesby extending the sharedPaginationQueryDto(defaults: page=1, limit=10, max=100)em.find()toem.findAndCount()withlimit/offset, returning{ data, meta }paginated responses withPaginationMetaDepartmentListResponseDto,ProgramListResponseDto, andCourseListResponseDtofollowing the established codebase pattern (matches admin, faculty, dimensions modules)Test plan
npm run lintpassesnpm run buildpassesCloses #209
https://claude.ai/code/session_01Ug6JLCMPhy42Skcq7tWyVV